Fix IRR Calculation Inconsistencies Across Different CPUs #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved inconsistent IRR results observed across different CPU architectures by implementing a multi-iteration stabilization approach in the `irr` function. Changes include: - Added an `iterations` parameter to calculate IRR multiple times to reduce fluctuations caused by numerical differences between CPUs. - Introduced a tolerance (`tol`) to verify if multiple IRR results are stable. If results are within the tolerance range, they are averaged. - Implemented a fallback to the median IRR result if inconsistencies persist. - Ensured that the calculation handles cases with no real solution gracefully. This update aims to make IRR calculations reliable across various hardware configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved inconsistent IRR results observed across different CPU architectures by implementing a multi-iteration stabilization approach in the
irrfunction.Changes include:
iterationsparameter to calculate IRR multiple times to reduce fluctuations caused by numerical differences between CPUs.tol) to verify if multiple IRR results are stable. If results are within the tolerance range, they are averaged.This update aims to make IRR calculations reliable across various hardware configurations.