Skip to content

Address comments from code review. #2479

Address comments from code review.

Address comments from code review. #2479

Triggered via push February 21, 2024 18:51
Status Failure
Total duration 22m 21s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: build-nodefault
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 5 warnings
Rustfmt
Process completed with exit code 1.
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
using `clone` on type `sapling_crypto::keys::OutgoingViewingKey` which implements the `Copy` trait: zcash_client_backend/src/data_api/wallet.rs#L875
error: using `clone` on type `sapling_crypto::keys::OutgoingViewingKey` which implements the `Copy` trait --> zcash_client_backend/src/data_api/wallet.rs:875:51 | 875 | OvkPolicy::Custom { sapling, .. } => Some(sapling.clone()), | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*sapling` | = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `sapling_crypto::keys::OutgoingViewingKey` which implements the `Copy` trait: zcash_client_backend/src/data_api/wallet.rs#L875
error: using `clone` on type `sapling_crypto::keys::OutgoingViewingKey` which implements the `Copy` trait --> zcash_client_backend/src/data_api/wallet.rs:875:51 | 875 | OvkPolicy::Custom { sapling, .. } => Some(sapling.clone()), | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*sapling` | = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Clippy (MSRV)
Clippy had exited with the 101 exit code
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
protobuf consistency
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: supplypike/setup-bin@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/