Skip to content
CI checks

zcash_client_backend: Factor out common note decryption from `scan_bl… #2493

Sign in to view logs

zcash_client_backend: Factor out common note decryption from `scan_bl…

zcash_client_backend: Factor out common note decryption from `scan_bl… #2493

GitHub Actions / Clippy (MSRV) failed Feb 23, 2024 in 0s

Clippy (MSRV)

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.65.0 (897e37553 2022-11-02)
  • cargo 1.65.0 (4bc8f24d3 2022-10-20)
  • clippy 0.1.65 (897e375 2022-11-02)

Annotations

Check failure on line 733 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant slicing of the whole range 

error: redundant slicing of the whole range
   --> zcash_client_backend/src/scanning.rs:733:55
    |
733 |             batch::try_compact_note_decryption(&ivks, &decoded[..])
    |                                                       ^^^^^^^^^^^^ help: use the original value instead: `decoded`
    |
    = note: `-D clippy::redundant-slicing` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing

Check failure on line 687 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this function has too many arguments (13/7) 

error: this function has too many arguments (13/7)
   --> zcash_client_backend/src/scanning.rs:653:1
    |
653 | / fn find_notes<
654 | |     M,
655 | |     D: BatchDomain,
656 | |     SK: ScanningKey<Note = D::Note>,
...   |
686 | |     Vec<(NoteCommitment, Retention<BlockHeight>)>,
687 | | ) {
    | |_^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check failure on line 733 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant slicing of the whole range 

error: redundant slicing of the whole range
   --> zcash_client_backend/src/scanning.rs:733:55
    |
733 |             batch::try_compact_note_decryption(&ivks, &decoded[..])
    |                                                       ^^^^^^^^^^^^ help: use the original value instead: `decoded`
    |
    = note: `-D clippy::redundant-slicing` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing

Check failure on line 687 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

this function has too many arguments (13/7) 

error: this function has too many arguments (13/7)
   --> zcash_client_backend/src/scanning.rs:653:1
    |
653 | / fn find_notes<
654 | |     M,
655 | |     D: BatchDomain,
656 | |     SK: ScanningKey<Note = D::Note>,
...   |
686 | |     Vec<(NoteCommitment, Retention<BlockHeight>)>,
687 | | ) {
    | |_^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
View more details on GitHub Actions