fix(links): Skip links without a url - #1186
Merged
kristijanhusak merged 1 commit intoSep 21, 2026
Merged
Conversation
Member
|
There should be no empty diff --git a/lua/orgmode/files/file.lua b/lua/orgmode/files/file.lua
index 632b5b2..17d9d95 100644
--- a/lua/orgmode/files/file.lua
+++ b/lua/orgmode/files/file.lua
@@ -857,7 +857,7 @@ function OrgFile:get_links()
local links = {}
local matches = self:get_ts_captures([[
(link) @link
- (link_desc) @link
+ (link_desc url: (expr)+) @link
]])
local source = self:get_source()
|
A link like [[][desc]] parses into a link_desc node without a url field. Collecting links from such a file crashed on reading the missing node instead of ignoring the malformed link. Match only link_desc nodes that have a url in the get_links query, so the malformed ones never reach the hyperlink constructor.
seflue
force-pushed
the
fix/empty-link-nil-url
branch
from
September 20, 2026 23:53
a7acae1 to
ab6c4e4
Compare
Contributor
Author
|
Checked the tree with 2.0.4: Switched to your query filter and dropped the nil check in
|
kristijanhusak
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing
[[]]into an org file, for example while starting a link, breaks every caller ofOrgFile:get_links()until the brackets are filled:The grammar still produces a
linknode for the empty brackets, but without aurlfield. Same for[[][desc]].from_nodenow returns nil for a link node without a url.get_linksskips those nodes; theat_cursorcallers already handle nil.