Skip to content

Commit

Permalink
fix(bld): parse options.app.icon correctly during build mode
Browse files Browse the repository at this point in the history
  • Loading branch information
ayushmanchhabra committed Nov 25, 2024
1 parent 6ab1ea3 commit bd0ef96
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/bld.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ const setLinuxConfig = async ({ app, outDir }) => {
GenericName: app.genericName,
NoDisplay: app.noDisplay,
Comment: app.comment,
Icon: path.resolve(outDir, 'package.nw', path.basename(app.icon)),
Icon: app.icon ? path.resolve(outDir, 'package.nw', app.icon) : '',
Hidden: app.hidden,
OnlyShowIn: app.onlyShowIn,
NotShowIn: app.notShowIn,
Expand Down
2 changes: 1 addition & 1 deletion src/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export const parse = async (options, pkg) => {
options.app.name = options.app.name.replace(/[<>:"/\\|?*\u0000-\u001F]/g, '');
}
/* Path to where the icon currently is in the filesystem */
options.app.icon = options.app.icon ?? undefined;
options.app.icon = options.app.icon ?? pkg.window?.icon ?? undefined;
if (options.app.icon) {
options.app.icon = path.resolve(options.app.icon);
}
Expand Down

0 comments on commit bd0ef96

Please sign in to comment.