Add Max Block Height Service #113
Open
+182
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45930
requested changes
Jan 10, 2025
| @@ -78,4 +83,5 @@ type ActionOutput { | |||
| type Query { | |||
| events(input: EventFilterOptionsInput!): [EventOutput]! | |||
| actions(input: ActionFilterOptionsInput!): [ActionOutput]! | |||
| block: MaxBlockHeightInfo! | |||
There was a problem hiding this comment.
I think it would make more sense in the long run for this query to be called blockchainMetadata or something, so there is scope to add additional data in the future.
| }); | ||
| }); | ||
|
|
||
| test("Fetching the max block height should return the max block height", async () => { |
There was a problem hiding this comment.
It would be nice to add more serious testing to this. For example, if we progress the state of the blockchain, does the block height advance? Does the pending height stay higher than the canonical height?
There was a problem hiding this comment.
You could also use the mina grapqhQL endpoint as a source of truth to compare and make sure we are actually returning the max block height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature to fetch the maximum block height information from an archive node. This information can then be used to check the synchronization of archive nodes with Mina nodes.
The query below returns
canonicalMaxBlockHeightandpendingMaxBlockHeight:closes #111