Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(--target): RUSTDOCFLAGS=--cap-lints=warn #1071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zjp-CN
Copy link

@zjp-CN zjp-CN commented Jan 8, 2025

close #1068

Cargo relies on warning diagnostics to find information, --cap-lints=allow eliminates the warnings, so set the value to warn level to keep it.

close obi1kenobi#1068

Cargo relies on warning diagnostics to find information,
--cap-lints=allow eliminates the warnings, so set the value to
warn level to keep it.
@obi1kenobi
Copy link
Owner

I'm pretty worried about the possibility of something along the lines of -Dwarnings (either in code as a #[deny], or in the CLI, or in some config file) that causes those generated warnings to turn into errors. We added --cap-lints precisely because of -Dwarnings style issues.

I'd be open to merging such a change if you could include tests and test crates that check as many of those cases as possible, so that we know that --cap-lints=warn is sufficient and won't just cause something else to explode. I'd be happy to point you in the right direction for writing those test cases, I just want to first check if you're open to doing that :)

@zjp-CN
Copy link
Author

zjp-CN commented Jan 10, 2025

Thanks for reminding me of -Dwarnings...

The fix here is unnecessary if rust-lang/cargo#15036 lands on nightly in a few days. I'll close this PR when it works.

I can submit a testcast that needs --target argument in another PR. But there seems to have one already?

Update: open #1073 for target testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants