(ood-gen) Adjust type of fields with bool option type to bool in Release #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves task no. 2 of #2051, for now.
In
planet.ml(task no. 1) there is nothing to do because all fields with typebool optionbelong tometadata-like types (I am including hereExternal.Source.t)In
workshop.ml(task no. 3) I can adjust the type ofWorkshop.presentation.posterbut the solution might not improve the code as well. IMO the only way to handle the fields ofWorkshop.presentationwithoptiontype is by creating another type from it, and use the latter inWorkshop.t.presentationsinstead, only this time I would use ppx_stable and renamepresentationtopresentation_metadataor something more readable.