Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better char array support #353

Merged
merged 1 commit into from
Oct 31, 2023
Merged

better char array support #353

merged 1 commit into from
Oct 31, 2023

Conversation

zhuoqiang
Copy link
Contributor

quill treats c array as c string and use strlen() to get the size of the c array buffer, which is not safe if the c array contain no \0 at all.

this patch uses strnlen() and array size to fix this issue #351

@zhuoqiang zhuoqiang mentioned this pull request Sep 18, 2023
Closed
@odygrd
Copy link
Owner

odygrd commented Oct 31, 2023

Thanks for PR. It looks good to me. For some reason I can not trigger the CI tests so i am going to try to move it to another branch

@odygrd odygrd changed the base branch from master to char_array_support October 31, 2023 23:41
@odygrd odygrd merged commit ebf276a into odygrd:char_array_support Oct 31, 2023
1 check passed
@odygrd odygrd mentioned this pull request Oct 31, 2023
Merged
@p-linnane p-linnane mentioned this pull request Nov 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhuoqiang @odygrd