Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10 - Add missing <title> tag #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#10 - Add missing <title> tag #11

wants to merge 2 commits into from

Conversation

SebinSong
Copy link
Collaborator

closes #10

@SebinSong SebinSong self-assigned this Nov 3, 2024
SebinSong
SebinSong commented Nov 3, 2024
View reviewed changes
src/components/head-override/HeadCommon.astro
const { entry } = Astro.props

// [Reference] Fetching page-title from the page's frontmatter: https://starlight.astro.build/guides/overriding-components/
const pageTitle = `${entry?.data.title || ''} 🚀 ${SITE.title}`
Copy link
Collaborator Author

@SebinSong SebinSong Nov 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I'm using the same title as in HeadSEO.astro (below):

shelterprotocol.net/src/components/head-override/HeadSEO.astro

Line 9 in b54ecc8

const formattedContentTitle = `${title} 🚀 ${SITE.title}`

But let me know if we want to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SebinSong SebinSong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add <title> tag
1 participant
@SebinSong