Conversation
thatch
marked this pull request as ready for review
April 25, 2026 14:44
thatch
force-pushed
the
thatch/stdin-no-write
branch
from
May 15, 2026 03:33
66ed902 to
a2e6ca2
Compare
thatch
changed the title
thatch
force-pushed
the
thatch/stdin-no-write
branch
from
May 15, 2026 03:36
a2e6ca2 to
b919656
Compare
With test. I'm not sure if diff makes sense to keep though.
thatch
force-pushed
the
thatch/stdin-no-write
branch
from
May 15, 2026 03:38
b919656 to
d967ccc
Compare
Member
|
My concern with this is user tooling that doesn't check the exit code when formatting stdin, and just blindly takes the resulting code and writes it to wherever. I'd rather the tool output unchanged original content along with an exit code than have workflows accidentally erase the entire file because they didn't check exit codes. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With test. I'm not sure if diff makes sense to keep though.