Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update atuin to v18.1.0 #1361

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Update atuin to v18.1.0 #1361

merged 1 commit into from
Mar 14, 2024

Conversation

papertigers
Copy link
Contributor

Version 17.0.0 just released: https://github.com/atuinsh/atuin/releases/tag/v17.0.0

I haven't run through a build of this, but I am filing the PR anyways.

oetiker
oetiker previously approved these changes Oct 29, 2023
build/atuin/build.sh Outdated Show resolved Hide resolved
Copy link
Member

@hadfl hadfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the build seems to fail, we'd appreciate if you could have a look and fix it if possible. Thanks

@papertigers
Copy link
Contributor Author

I have filed atuinsh/atuin#1361

There are two things we can do:

The first option didn't pass tests, so I will need to setup an OmniOS version with X11 to make more progress.
The second option seems like the easier path at the moment, so I will find some time to put that together soon.

@oetiker
Copy link
Member

oetiker commented Jan 4, 2024

any progress ?

@papertigers
Copy link
Contributor Author

Sorry haven't had time to put together the necessary patch on the atuin side.
Let me see if I can make some time soon to push that along.

@citrus-it citrus-it changed the title Update atuin to v17.0.0 Update atuin to v18.1.0 Mar 13, 2024
@citrus-it
Copy link
Member

18.1.0 fixes this, and also fixes some undefined behaviour on illumos. I've updated the PR.

@citrus-it citrus-it requested review from hadfl and oetiker March 13, 2024 15:30
@citrus-it citrus-it merged commit 5fffc5a into omniosorg:master Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants