-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add starship shell prompt #1567
Conversation
d27d66b
to
9b9ee89
Compare
Sorry about the extra force pushes - my editor messed up the formatting on the MD table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the runtime warnings, the unnecessary libraries doesn't matter much (although it would be nice to clean that up - is it something in rust itself?) but can you look at patching Cargo.toml
's [profile.release]
section so that it doesn't strip the binary itself? Then the strip_install
line you have in the script will take care of it but preserve the symbol table for us.
==== opt/ooce/bin/starship ====
NEEDED=librt.so.1 <dependency no longer necessary>
NEEDED=libpthread.so.1 <dependency no longer necessary>
symbol table should not be stripped <remove -s?>
I believe this is a rust thing:
|
This adds the starship prompt package https://starship.rs
I have been compiling this and distributing to hosts/zones manually but it would be nice to have in pkg.
The pkg successfully builds on my build box but complains about ELF runtimes and stack smashing which I think are safe to ignore iirc?