generic:sycl: Inner Product Backward #2360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
ranukund
reviewed
Jan 9, 2025
| * Supported post-ops: All the post operations as mentioned in the specification are supported. | ||
| * Supported data types: All possible data combinations as listed in the specification are supported. | ||
| * Supported post-ops: All the post-ops as mentioned in the specification are supported. | ||
| * The backward pass does not support post-ops. One should not use post-ops in the forward pass during training |
There was a problem hiding this comment.
I think this sentence could be included in a note format as opposed to listing this as a bullet.
Suggested change
| * The backward pass does not support post-ops. One should not use post-ops in the forward pass during training | |
| Note: The backward pass does not support post-ops. You should not use post-ops in the forward pass during training. |
| * Supported data types: All possible data combinations listed in the oneDNN specification are supported. | ||
| * Supported post-ops: All the post operations as mentioned in the specification are supported. | ||
| * Supported data types: All possible data combinations as listed in the specification are supported. | ||
| * Supported post-ops: All the post-ops as mentioned in the specification are supported. |
There was a problem hiding this comment.
Suggested change
| * Supported post-ops: All the post-ops as mentioned in the specification are supported. | |
| * Supported post-ops: All post-ops mentioned in the specification are supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the backward_data and the backward_weight of the inner product for the generic backend
Fixes # (github issue)
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?