doc: clarify conversions can be impacted by double-rounding #2361
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
ranukund
reviewed
Jan 9, 2025
| @@ -99,7 +99,12 @@ No downconversions are allowed by default, but can be enabled using | |||
| the floating-point math controls described in @ref | |||
| dev_guide_attributes_fpmath_mode. | |||
|
|
|||
|
|
|||
| The \f$convert_{dst\_dt}\f$ conversion is not guaranteed to be correctly | |||
There was a problem hiding this comment.
Will this be the result of the conversion is not guaranteed to be correctly rounded to the nearest value?
|
|
||
| The \f$convert_{dst\_dt}\f$ conversion is not guaranteed to be correctly | ||
| rounded. In particular, some hardware platforms have no direct | ||
| conversion instructions from f32 to low-precision datatypes (e.g. fp8 |
There was a problem hiding this comment.
Suggested change
| conversion instructions from f32 to low-precision datatypes (e.g. fp8 | |
| conversion instructions to convert f32 data types to low-precision data types such as fp8 |
| The \f$convert_{dst\_dt}\f$ conversion is not guaranteed to be correctly | ||
| rounded. In particular, some hardware platforms have no direct | ||
| conversion instructions from f32 to low-precision datatypes (e.g. fp8 | ||
| or fp4), and will perform conversion through an intermediate datatype |
There was a problem hiding this comment.
Suggested change
| or fp4), and will perform conversion through an intermediate datatype | |
| or fp4, and will perform conversion through an intermediate data type |
| rounded. In particular, some hardware platforms have no direct | ||
| conversion instructions from f32 to low-precision datatypes (e.g. fp8 | ||
| or fp4), and will perform conversion through an intermediate datatype | ||
| (e.g. f16/bf16), which may cause [double |
There was a problem hiding this comment.
Suggested change
| (e.g. f16/bf16), which may cause [double | |
| (for example, f16 or bf16), which may result in [double |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify in the documentation that there could be double rounding going on when converting f32 to very low accuracy datatypes (fp4/fp8).