Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xe: jit: gemm: remove mixing of oneDNN and gemmstone code #2363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rjoursler
Copy link
Contributor

As a side-effect, also enables targeting an out-of-tree gemmstone by setting ONEDNN_GEMMSTONE_DIR.

@rjoursler rjoursler requested a review from a team as a code owner January 9, 2025 20:18
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Jan 9, 2025
@rjoursler
Copy link
Contributor Author

make test
disable device_cpu
disable device_gpu

@petercad
Copy link
Contributor

petercad commented Jan 9, 2025

@rjoursler Is the idea to then move gemmstone to the third-party directory? The directories are getting buried pretty deep :)

@rjoursler rjoursler force-pushed the rjoursle/separate_gemmstone branch from ad1be7b to 105ef7e Compare January 9, 2025 20:46
As a side-effect, also enables targeting an out-of-tree gemmstone by setting
ONEDNN_GEMMSTONE_DIR.
@rjoursler rjoursler force-pushed the rjoursle/separate_gemmstone branch from 105ef7e to a258080 Compare January 9, 2025 20:51
@rjoursler
Copy link
Contributor Author

@rjoursler Is the idea to then move gemmstone to the third-party directory?

That is the basic idea, or more accurately, to get that process started. According to this comment, there is likely a bit too much entanglement between the projects to move into the proposed thirdparty location.

The directories are getting buried pretty deep :)

Do you have a preferred location? I had considered moving this gpu/intel/jit/gemmstone or even gpu/intel/gemmstone, but wasn't sure on developers opinions.

@petercad
Copy link
Contributor

petercad commented Jan 9, 2025

Do you have a preferred location? I had considered moving this gpu/intel/jit/gemmstone or even gpu/intel/gemmstone, but wasn't sure on developers opinions.

gpu/intel/jit/gemmstone is fine by me, but of course it doesn't matter much if we're going to move gemmstone to third_party "really soon." FYI, OV has to modify a bit of code on their side every time we move gemmstone around, so it's probably best to delay this PR until rls-v3.7 is branched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants