Skip to content

Commit

Permalink
newer setuptools compatibility; silence pylint warnings on too many a…
Browse files Browse the repository at this point in the history
…rguments for scenarion ctor (#92)
  • Loading branch information
slayoo authored Dec 8, 2023
1 parent da7ac35 commit 735302a
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 4 deletions.
18 changes: 16 additions & 2 deletions .github/workflows/tests+pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,8 @@ jobs:
name: plots
path: plots

dist:
package:
runs-on: ubuntu-latest
needs: [tests]
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -153,8 +152,23 @@ jobs:
unset CI
python -m build 2>&1 | tee build.log
exit `fgrep -i warning build.log | wc -l`
- run: twine check --strict dist/*

- uses: actions/upload-artifact@v2
with:
name: dist
path: dist

dist:
runs-on: ubuntu-latest
needs: [package,tests]
steps:
- uses: actions/download-artifact@v2
with:
name: dist
path: dist

- if: github.event_name == 'push' && github.ref == 'refs/heads/main'
uses: pypa/gh-action-pypi-publish@unstable/v1
with:
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
[tool.setuptools]
py-modules = []

[tool.setuptools_scm]

[build-system]
requires = ["setuptools", "setuptools-scm"]
build-backend = "setuptools.build_meta"
Expand Down
2 changes: 1 addition & 1 deletion scenarios/cartesian.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class CartesianScenario(_Scenario):
[Arabas et al. 2014](https://doi.org/10.3233/SPR-140379)
"""

def __init__(
def __init__( # pylint: disable=too-many-arguments
self,
*,
mpdata_options,
Expand Down
2 changes: 1 addition & 1 deletion scenarios/spherical.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class SphericalScenario(_Scenario):
[Williamson & Rasch 1989](https://doi.org/10.1175/1520-0493(1989)117<0102:TDSLTW>2.0.CO;2)
"""

def __init__(
def __init__( # pylint: disable=too-many-arguments
self, *, mpdata_options, n_threads, grid, rank, size, courant_field_multiplier
):
# pylint: disable=too-many-locals,invalid-name
Expand Down

0 comments on commit 735302a

Please sign in to comment.