Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump versions of artifact actions, plint and pdoc compat fixes #126

Merged
merged 7 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/tests+pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
run: |
pip install pdoc
pip install -e .
python -We -m pdoc -o html PyMPDATA_MPI
PDOC_ALLOW_EXEC=1 python -We -m pdoc -o html PyMPDATA_MPI
- name: Deploy
if: github.ref == 'refs/heads/main'
uses: JamesIves/[email protected]
Expand Down Expand Up @@ -216,9 +216,9 @@ jobs:
pip install pytest-cov
fi
NUMBA_NUM_THREADS=3 mpiexec $_mpiexec_args -n ${{ matrix.mpi-np }} python -m pytest -p no:cacheprovider $COV_ARGS --timeout=600 --timeout_method=thread -s -vv -We tests/local;
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: plots
name: plots-${{matrix.mpi-np}}
path: plots
- if: env.CODECOV_RUN == '1'
uses: codecov/codecov-action@v4
Expand Down Expand Up @@ -246,7 +246,7 @@ jobs:

- run: twine check --strict dist/*

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: dist
path: dist
Expand All @@ -255,7 +255,7 @@ jobs:
runs-on: ubuntu-latest
needs: [package,tests]
steps:
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: dist
path: dist
Expand Down Expand Up @@ -287,9 +287,10 @@ jobs:
runs-on: ubuntu-latest
needs: [tests, devops_tests]
steps:
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: plots
pattern: plots-*
merge-multiple: true
path: plots
- run: |
sudo apt install -y librsvg2-bin
Expand All @@ -306,7 +307,7 @@ jobs:
done;
done;

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: anims
path: plots/*-anim.gif
Expand Down
2 changes: 1 addition & 1 deletion PyMPDATA_MPI/impl/boundary_condition_commons.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments,too-many-arguments
""" boundary_condition common functions """

from functools import lru_cache
Expand Down
2 changes: 1 addition & 1 deletion PyMPDATA_MPI/impl/mpi_boundary_condition.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def make_get_peer(_, __):
"""returns (lru-cached) numba-compiled callable."""
raise NotImplementedError()

# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments,too-many-arguments
def make_scalar(self, indexers, halo, dtype, jit_flags, dimension_index):
"""returns (lru-cached) Numba-compiled scalar halo-filling callable"""
if self.__mpi_size_one:
Expand Down
2 changes: 1 addition & 1 deletion PyMPDATA_MPI/mpi_periodic.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def __init__(self, size, mpi_dim):

super().__init__(size=size, base=Periodic, mpi_dim=mpi_dim)

# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments,too-many-arguments
def make_vector(self, indexers, halo, dtype, jit_flags, dimension_index):
"""returns (lru-cached) Numba-compiled vector halo-filling callable"""
if self.worker_pool_size == 1:
Expand Down
Loading