Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new example: buoyant-bubble with a Boussinesq system (velocity extrapolation in time + pressure solver); devops tests bump #495

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Jan 5, 2025

No description provided.

@slayoo
Copy link
Member Author

slayoo commented Jan 5, 2025

@Caastlefox, not to forget:

  • label for the colorscale (temperature [K])
  • brief description of what equations are solved, and where the settings originate from
  • @jit decorator for more functions
  • at least a minimal smoke test

To fix the precommit formatting issue, you need to pip install pre-commit, and then either do pre-commit install (which will trigger pre-commit formatting changes before each commit) or trigger the scan manually with pre-commit run --all-files. HTH

@Caastlefox Caastlefox force-pushed the development branch 3 times, most recently from bf0ee03 to 7fa6b92 Compare January 6, 2025 10:54
@slayoo slayoo changed the title new example: buoyant-bubble with a Boussinesq system (velocity extrapolation in time + pressure solver) new example: buoyant-bubble with a Boussinesq system (velocity extrapolation in time + pressure solver); devops tests bump Jan 6, 2025
variable  output changed from list to np.ndarray
variable freq added to change frequency of  animated data(plotting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants