chore: Remove bare except

open-contracting · Sep 15, 2024 · 10d9ad9 · 10d9ad9
1 parent fbe0fe4
commit 10d9ad9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/tests/commands/test_load.py b/tests/commands/test_load.py
@@ -80,10 +80,7 @@ def test_time_invalid(self):
     @patch("yapw.methods.publish")
     def test_source_invalid(self, publish):
         with captured_stderr() as stderr:
-            try:
-                call_command("load", "--source", "nonexistent", "--note", "x", path("file.json"))
-            except Exception as e:
-                self.fail(f"Unexpected exception {e}")
+            call_command("load", "--source", "nonexistent", "--note", "x", path("file.json"))  # no error
 
             self.assertTrue(
                 "The --source argument can't be validated, because a Scrapyd URL is not configured in "
@@ -122,21 +119,15 @@ def test_source_invalid_scrapyd_force(self, spiders, publish):
         spiders.return_value = ["france"]
 
         with self.settings(SCRAPYD={"url": "http://example.com", "project": "kingfisher"}):
-            try:
-                call_command("load", "--source", "nonexistent", "--note", "x", "--force", path("file.json"))
-            except Exception as e:
-                self.fail(f"Unexpected exception {e}")
+            call_command("load", "--source", "nonexistent", "--note", "x", "--force", path("file.json"))  # no error
 
     @patch("process.scrapyd.spiders")
     @patch("yapw.methods.publish")
     def test_source_local(self, spiders, publish):
         spiders.return_value = ["france"]
 
         with self.settings(SCRAPYD={"url": "http://example.com", "project": "kingfisher"}):
-            try:
-                call_command("load", "--source", "france_local", "--note", "x", "--force", path("file.json"))
-            except Exception as e:
-                self.fail(f"Unexpected exception {e}")
+            call_command("load", "--source", "france_local", "--note", "x", "--force", path("file.json"))  # no error
 
     def test_unique_deleted_at(self):
         source = collection(deleted_at="2001-01-01 00:00:00")

diff --git a/tests/test_models.py b/tests/test_models.py
@@ -37,10 +37,7 @@ def test_clean_fields_existing_transform(self):
         obj = collection(parent=source, transform_type="compile-releases")
         obj.save()
 
-        try:
-            obj.clean_fields()
-        except Exception as e:
-            self.fail(f"Unexpected exception {e}")
+        obj.clean_fields()  # no exception
 
     def test_clean_fields_conditionally_mandatory(self):
         source = collection()