Cleanup migrations #5013
Open
Cleanup migrations #5013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And convert the squashed migration to a regular migration.
Removed the replaced original migrations, converted the squashed migratio to a regular migration and removed the RunPython operation that's guaranteed to have been executed on Open Forms 3.0.x.
Removed the replaced original migrations, converted the squashed migration to a regular migration and removed the RunPython operations that are guaranteed to have been executed on Open Forms 3.0.x.
Removed the replaced original migrations, converted the squashed migration to a regular migration.
Removed the replaced original migrations, converted the squashed migration to a regular migration. The RunPython operations have been removed since they're guaranteed to have been executed on Open Forms 3.0.x.
Removed the replaced original migrations, converted the squashed migration to a regular migration.
The data migrations that needed to be performed on older instances are now removed, since the upgrade checks guarantee that they have been executed during upgrades to 3.0.x. For new instances, these operations were not relevant in the first place. This allows us to remove migration test code which speeds up the test suite and leads to less code to maintain.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5013 +/- ##
==========================================
- Coverage 96.66% 96.62% -0.05%
==========================================
Files 761 761
Lines 25959 25958 -1
Branches 3394 3394
==========================================
- Hits 25093 25081 -12
- Misses 601 611 +10
- Partials 265 266 +1 ☔ View full report in Codecov by Sentry. |
Now that all migration tests are removed and migrations are squashed, we should be able to perform this schema migration.
Upgrading from 2.8.x directly is not possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4654
This cleans up the migrations that were squashed as part of the 3.0 release.
Obsolete
RunPythonoperations have been removed since they are guaranteed to already have been executed as part of the 3.0 upgrade.