fix: escape non-standard characters in the filename path #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nickytonline
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Tests pass, I installed it locally and successfully updated the CODEOWNERS file for the app repository, open-sauced/app#4052.
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
## [1.2.0-beta.6](v1.2.0-beta.5...v1.2.0-beta.6) (2024-08-28) ### 🐛 Bug Fixes * escape non-standard characters in the filename path ([#106](#106)) ([418951f](418951f))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
## [1.2.0](v1.1.1...v1.2.0) (2024-08-30) ### 📝 Documentation * updated comment for LoadConfig ([ab5206b](ab5206b)) ### ✅ Tests * added setup and teardown ([aba6310](aba6310)) * added tests for LoadConfig ([2a5f85d](2a5f85d)) * made tests parallel ([2b3d8ca](2b3d8ca)) ### 🍕 Features * added .sauced.yaml and updated CODEOWNERS file ([#109](#109)) ([dfc56cb](dfc56cb)) * added built at to version command ([#94](#94)) ([9960fc0](9960fc0)) * Codeowners generation ([#95](#95)) ([79cf8a2](79cf8a2)) * now generate codeowners checks in user root but also repository root folder for .sauced.yaml ([a0298b1](a0298b1)) * pizza login success page style refresh ([#112](#112)) ([9357dac](9357dac)) * Refactors Auth code into api/ directory ([#105](#105)) ([d851499](d851499)) * Skip semantic-release docker build in favor of buildx building ([d782974](d782974)) * Trim down CLI - remove unused, defunct commands ([#93](#93)) ([7ddd4b9](7ddd4b9)) * Upgrade Go module to use Go 1.22 ([#96](#96)) ([690b6e9](690b6e9)) * Use justfile vs. makefile ([#84](#84)) ([8f38eaf](8f38eaf)) ### 🐛 Bug Fixes * escape non-standard characters in the filename path ([#106](#106)) ([418951f](418951f)) * mark endpoint and beta flags as hidden ([#113](#113)) ([6aa250f](6aa250f)) * move output flag to insights command ([#115](#115)) ([be7f8cd](be7f8cd)) * update supabase keys for auth ([#80](#80)) ([247c431](247c431)) * use repository fullname to fetch contributors ([#77](#77)) ([5326875](5326875))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
\when generating a CODEOWNERS filepizza generate codeownerswith renamed files creates invalid entry #101. Not the recommended fix, but a workaround for now.Related Tickets & Documents
Closes #100
Mobile & Desktop Screenshots/Recordings
Steps to QA
cmd/generate/codeowners/output_test.goand inspect test filejust testTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?