-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: now generate codeowners checks in user root but also repository root folder for .sauced.yaml #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
commented
Aug 28, 2024
nickytonline
force-pushed
the
nickytonline/autodetect-sauced-yaml
branch
from
August 28, 2024 21:30
ac7ba39
to
10468ff
Compare
4 tasks
nickytonline
commented
Aug 28, 2024
nickytonline
commented
Aug 28, 2024
jpmcb
requested changes
Aug 28, 2024
… root folder for .sauced.yaml
Co-authored-by: John McBride <[email protected]>
Co-authored-by: John McBride <[email protected]>
Co-authored-by: John McBride <[email protected]>
nickytonline
force-pushed
the
nickytonline/autodetect-sauced-yaml
branch
from
August 29, 2024 00:01
06d1eca
to
c833602
Compare
nickytonline
force-pushed
the
nickytonline/autodetect-sauced-yaml
branch
from
August 29, 2024 00:03
c833602
to
aba6310
Compare
jpmcb
approved these changes
Aug 29, 2024
nickytonline
commented
Aug 29, 2024
brandonroberts
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node the generate codeowners command checks for .sauced.yaml in
~/.sauced.yaml
andopts.path + "/.sauced.yaml"
.Related Tickets & Documents
Closes #102
Mobile & Desktop Screenshots/Recordings
Steps to QA
just install
pizza generate codeowners some/path
.a. Try without a some/path/.sauced.yaml file (fails)
b. Try with a some/path/.sauced.yaml file (generates CODEOWNERS file)
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?