Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Pizza Action to Latest Version () #220

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

Bashamega
Copy link
Contributor

Description

I have updated the gh action

Related Tickets & Documents

fixes #206

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@jpmcb jpmcb requested a review from nickytonline October 14, 2024 21:43
@nickytonline
Copy link
Member

@jpmcb, I think we need to add a tag v2 for this to work? Right now it shows it as an invalid version if you use @v2.

@jpmcb
Copy link
Member

jpmcb commented Oct 15, 2024

Ah, that's annoying. I just figured that was something the GitHub actions runtime resolved (i.e., if there was a v2.3.4 and you specified v2, it would automatically resolve to the latest major version). It could be nice for us to cut a v2 tag and point that tag to the latest releases on the pizza-action but that's probably too much overhead for us right now.

cc @Bashamega - feel free to revert to your previous change! Thanks!

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @jpmcb's comment, we'll put the explicit version for now as we don't have a v2 tag at the moment and then this is good to go.

.github/workflows/pizza.yml Outdated Show resolved Hide resolved
@nickytonline nickytonline merged commit 39e7f74 into open-sauced:beta Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Update Pizza Action to Latest Version
4 participants