Demo: Offer TLS settings for remote connections #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offer example code for setting the TLS min version through the proposed new TLSConnectionSettings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to go along with open-telemetry/opamp-spec#205
The example agent has been expanded with the ability to accept various TLS settings for the OpAMP connection.
In order to demo this; this start both the example agent and server, then view the agent in the server UI. There is a new OpAMP connections settings area with the ability to specify and send the TLS min version.
I've also included flags to demo the
Agent-initiated CA trust Flowin the spec.The example server, when started with the
-send-caflag will inject the CA in response when an agent has requested a certificate.The example agent for this case should be started with the
-await-caflag, that forces it to start withInsecureSkipVerify: trueand it will expect to receive the CA that the server is using.