[receiver/solace]: Update the auth validation step #36386
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
atoulme
reviewed
Nov 16, 2024
atoulme
reviewed
Nov 16, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme @djaglowski hi, I made the changes. Can we move forward with the PR? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
atoulme
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36386 +/- ##
==========================================
+ Coverage 80.11% 80.70% +0.59%
==========================================
Files 2187 2265 +78
Lines 205259 222134 +16875
==========================================
+ Hits 164435 179265 +14830
- Misses 35471 37226 +1755
- Partials 5353 5643 +290 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The validation step should not allow configuring several auth methods when only one will be considered (the first one that's not nil in this order plain > xauth2 > external).
(technically this is a breaking change because some users might have several auth methods configured, but that doesn't make sense so it's unlikely to break many users if any)
Testing
One test with multiple auth methods was added.