[receiver/sqlquery] sqlserver integration tests, improved coverage #36922
+554
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grandys
force-pushed
the
sqlqueryreciver-improve-integration-tests
branch
from
2c462cc to
1bdd23c
Compare
Grandys
force-pushed
the
sqlqueryreciver-improve-integration-tests
branch
3 times, most recently
from
dc3dc6e to
1bdd23c
Compare
Grandys
force-pushed
the
sqlqueryreciver-improve-integration-tests
branch
from
3044d01 to
bba41e4
Compare
atoulme
reviewed
Jan 2, 2025
| BodyColumn: "body", | ||
| AttributeColumns: []string{"attribute"}, | ||
| }, | ||
| type DbEngine struct { |
There was a problem hiding this comment.
I would inexpert that type just to be clear about it
There was a problem hiding this comment.
@atoulme Thank you for your comment. I'm not entirely clear on what you mean. Are you suggesting that I should simply rename this type to DbEngineUnderTest?
Grandys
force-pushed
the
sqlqueryreciver-improve-integration-tests
branch
from
bba41e4 to
da67353
Compare
|
Failing extension test is frequency of #37079, I've added a reference there. Unrelated to this change. |
crobert-1
reviewed
Jan 7, 2025
| @@ -0,0 +1,12 @@ | |||
| FROM mcr.microsoft.com/mssql/server:2017-latest | |||
There was a problem hiding this comment.
Can we use a more recent version of the SQL Server docker image?
| /opt/mssql/bin/sqlservr & | ||
|
|
||
| # Wait for SQL Server to start | ||
| sleep 30s |
There was a problem hiding this comment.
Is there any way to have a more concrete/time sensitive check for this?
Grandys
force-pushed
the
sqlqueryreciver-improve-integration-tests
branch
from
da67353 to
49d5e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainly added test for sqlserver, plus added coverage for logs (as requested in comment)
Link to tracking issue
Fixes #29695
Testing
Main changes:
Improvements:
otelschema instead ofsys.Important: For Oracle and SQL Server, tests are skipped (tested locally) - I expect them to fail due to #27577 (which was not fixed but closed due to inactivity).