-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/bearerauthtoken] Custom auth header support for bearertokenauth #36986
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one tiny thing with the release note. wdyt?
I just wanted to highlight that its not a breaking change. Just an optional feature and it works when the extension is used as a client (RoundTripper
) or server (Authenticate
).
Adding a config param for bearertokenauth to use a http header other than "Authorization" to read the token param from
Description
Today the bearertokenauth (BTA) by default fetches the auth token from the http "Authorization" header. By allowing multiple auth headers this enables easier attribution as well as decoupling of an extension from a pipeline.
Link to tracking issue
Fixes #36985
Testing
Documentation
Please see the README.md update.