[chore] Build test tools in scoped tests action #37120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
added
Skip Changelog
pjanotti
commented
Jan 9, 2025
| @@ -59,6 +59,9 @@ jobs: | |||
| ./.tools | |||
| key: go-cache-${{ runner.os }}-${{ hashFiles('**/go.sum') }} | |||
|
|
|||
| - name: Build test tools | |||
| run: make "$(${PWD} -replace '\\', '/')/.tools/gotestsum" | |||
There was a problem hiding this comment.
This is not portable, but, right now the action runs only on Windows.
There was a problem hiding this comment.
In principle this could be conditional on the cache not being available, but, I'm afraid if the cache is saved via e2-to-e2-windows action it won't have the tools.
songy23
approved these changes
Jan 9, 2025
crobert-1
approved these changes
Jan 9, 2025
crobert-1
added
the
ready to merge
codeboten
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The new GH action is breaking because
gotestsumis not being built. I guess that in my fork the cache was always available when I tested. Anyway, building the tool to ensure the test works.Testing:
The same step is already in other actions I will be testing this concurrently in my fork.
Documentation:
N/A