Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consumer] Add new consumererrorprofiles module #11207

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 18, 2024

Description

Split off from #11131. Adds new module for consumer errors for profiles.

@mx-psi mx-psi requested a review from dmathieu September 18, 2024 11:36
@mx-psi mx-psi marked this pull request as ready for review September 18, 2024 11:38
@mx-psi mx-psi requested review from a team and dmitryax September 18, 2024 11:38
@mx-psi mx-psi force-pushed the mx-psi/consumererrorprofiles branch from e8cdfff to 60ebe2c Compare September 18, 2024 11:48
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (0f81b78) to head (c9aaecf).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11207   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         430      432    +2     
  Lines       20313    20321    +8     
=======================================
+ Hits        18671    18679    +8     
  Misses       1268     1268           
  Partials      374      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi requested a review from a team September 19, 2024 08:20
@mx-psi
Copy link
Member Author

mx-psi commented Oct 2, 2024

@open-telemetry/collector-approvers this is waiting on reviews!

@dmathieu
Copy link
Member

dmathieu commented Oct 7, 2024

This seems ready to be merged?

@mx-psi
Copy link
Member Author

mx-psi commented Oct 7, 2024

This seems ready to be merged?

Andrzej is not in the collector-approvers group, so I am still waiting for a review here 😢

@mx-psi mx-psi merged commit 5ac1607 into open-telemetry:main Oct 9, 2024
49 checks passed
@mx-psi mx-psi deleted the mx-psi/consumererrorprofiles branch October 9, 2024 13:46
@github-actions github-actions bot added this to the next release milestone Oct 9, 2024
mx-psi added a commit that referenced this pull request Oct 16, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from #11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires #11207✅  and #11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from open-telemetry#11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires open-telemetry#11207✅  and open-telemetry#11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Split off from open-telemetry#11131. Adds new module for consumer errors for profiles.

---------

Co-authored-by: Damien Mathieu <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from open-telemetry#11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires open-telemetry#11207✅  and open-telemetry#11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants