Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coding guideline for optional fields. #11342

Closed

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Oct 3, 2024

Description

Specify to use pointers to represent optional fields. This is a follow up to: #9478.

Link to tracking issue

Fixes #9478

Testing

Documentation

Specify to use pointers to represent optional fields. This is a follow up to: open-telemetry#9478.
@mackjmr mackjmr requested a review from a team as a code owner October 3, 2024 15:28
@mackjmr mackjmr requested a review from songy23 October 3, 2024 15:28
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 3, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (2d25853) to head (63028be).
Report is 181 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11342   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         428      428           
  Lines       20230    20230           
=======================================
  Hits        18519    18519           
  Misses       1337     1337           
  Partials      374      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with Evan, we may want to do a PoC of the hook that would be needed to support Optional to have a more concrete idea of the complexity we would be adding with this alternative.

@mackjmr
Copy link
Member Author

mackjmr commented Oct 10, 2024

@evan-bradley @yurishkuro @mx-psi I've taken a stab at this in #11409, can you please take a look ? I may be missing some edge cases.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 25, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confighttp] Review usage of 'pointer to type'
3 participants