-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coding guideline for optional fields. #11342
Add coding guideline for optional fields. #11342
Conversation
Specify to use pointers to represent optional fields. This is a follow up to: open-telemetry#9478.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11342 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 428 428
Lines 20230 20230
=======================================
Hits 18519 18519
Misses 1337 1337
Partials 374 374 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with Evan, we may want to do a PoC of the hook that would be needed to support Optional
to have a more concrete idea of the complexity we would be adding with this alternative.
@evan-bradley @yurishkuro @mx-psi I've taken a stab at this in #11409, can you please take a look ? I may be missing some edge cases. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
Specify to use pointers to represent optional fields. This is a follow up to: #9478.
Link to tracking issue
Fixes #9478
Testing
Documentation