-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate component_test in favor of metadatatest #11812
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
dep-comp-test
branch
4 times, most recently
from
December 6, 2024 15:38
22a7b42
to
8f96eed
Compare
bogdandrutu
force-pushed
the
dep-comp-test
branch
from
December 17, 2024 17:25
8f96eed
to
d078cae
Compare
bogdandrutu
force-pushed
the
dep-comp-test
branch
from
December 19, 2024 18:41
d078cae
to
dd54d23
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
bogdandrutu
force-pushed
the
dep-comp-test
branch
3 times, most recently
from
January 6, 2025 17:24
7414480
to
3ef0586
Compare
bogdandrutu
added
the
release:blocker
The issue must be resolved before cutting the next release
label
Jan 6, 2025
bogdandrutu
force-pushed
the
dep-comp-test
branch
2 times, most recently
from
January 6, 2025 17:36
74712f9
to
1691d9c
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
dep-comp-test
branch
from
January 6, 2025 17:48
1691d9c
to
5421d15
Compare
dmitryax
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
via the queue into
open-telemetry:main
with commit Jan 6, 2025
306c939
50 of 51 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea behind this is that the test helpers were generated in the main package, hard to find and understand and also impossible to use outside the main package, see the service/internal/proctelemetry/process_telemetry_test.go.