Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate component_test in favor of metadatatest #11812

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

bogdandrutu
Copy link
Member

The main idea behind this is that the test helpers were generated in the main package, hard to find and understand and also impossible to use outside the main package, see the service/internal/proctelemetry/process_telemetry_test.go.

@bogdandrutu bogdandrutu requested a review from a team as a code owner December 5, 2024 21:47
@bogdandrutu bogdandrutu requested a review from codeboten December 5, 2024 21:47
@bogdandrutu bogdandrutu force-pushed the dep-comp-test branch 4 times, most recently from 22a7b42 to 8f96eed Compare December 6, 2024 15:38
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 3, 2025
@bogdandrutu bogdandrutu removed the Stale label Jan 4, 2025
@bogdandrutu bogdandrutu force-pushed the dep-comp-test branch 3 times, most recently from 7414480 to 3ef0586 Compare January 6, 2025 17:24
@bogdandrutu bogdandrutu added the release:blocker The issue must be resolved before cutting the next release label Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 92.09726% with 26 lines in your changes missing coverage. Please review.

Project coverage is 91.70%. Comparing base (af09df1) to head (5421d15).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...r/internal/metadatatest/generated_telemetrytest.go 85.00% 6 Missing ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 85.00% 6 Missing ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 85.00% 6 Missing ⚠️
cmd/mdatagen/internal/command.go 50.00% 2 Missing and 1 partial ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 97.50% 1 Missing ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 97.50% 1 Missing ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 97.50% 1 Missing ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 97.50% 1 Missing ⚠️
...e/internal/metadatatest/generated_telemetrytest.go 97.14% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #11812    +/-   ##
========================================
  Coverage   91.70%   91.70%            
========================================
  Files         447      455     +8     
  Lines       23732    24053   +321     
========================================
+ Hits        21763    22058   +295     
- Misses       1600     1625    +25     
- Partials      369      370     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu force-pushed the dep-comp-test branch 2 times, most recently from 74712f9 to 1691d9c Compare January 6, 2025 17:36
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu enabled auto-merge January 6, 2025 18:04
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 6, 2025
Merged via the queue into open-telemetry:main with commit 306c939 Jan 6, 2025
50 of 51 checks passed
@bogdandrutu bogdandrutu deleted the dep-comp-test branch January 6, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants