[DebugExporter] Add EventName from LogRecord to output #11967
Merged
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Dec 20, 2024
trask
reviewed
Dec 20, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11967 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 455 455
Lines 24038 24040 +2
=======================================
+ Hits 22037 22039 +2
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
codeboten
reviewed
Dec 21, 2024
|
@codeboten The changelog CI check looks broken, unrelated to this PR. Could you help fix that, so this PR can have its CI check pass. |
andrzej-stencel
approved these changes
Jan 2, 2025
codeboten
approved these changes
Jan 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
#### Description 1. Adds event name from LogRecord to debug exporter. 2. Also modified the example config file to include logs too. (It only had traces/metrics). Not really required for this change, but hope that is okay to club into same PR! #### Link to tracking issue Fixes #11966 #### Testing Manually tested with Otel client that exported a LogRecord with event name and without event name. (1st time contributor here, still learning the process.) --------- Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Alex Boten <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #11966
Testing
Manually tested with Otel client that exported a LogRecord with event name and without event name.
(1st time contributor here, still learning the process.)