[chore]: enable early-return from revive #12061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
revive/early-return
branch
from
4eba585 to
b875f6c
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
revive/early-return
branch
from
b875f6c to
0c3a2ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12061 +/- ##
==========================================
- Coverage 91.67% 91.67% -0.01%
==========================================
Files 455 455
Lines 24038 24036 -2
==========================================
- Hits 22037 22035 -2
Misses 1629 1629
Partials 372 372 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Jan 9, 2025
bogdandrutu
approved these changes
Jan 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
open-telemetry:main
with commit Jan 10, 2025
07ed31a
84 of 90 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
early-return: In Go it is idiomatic to minimize nesting statements, a typical example is to avoid if-then-else constructions.