-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support output value in AttributeSetter #6543
Open
SodaDev
wants to merge
2
commits into
open-telemetry:main
Choose a base branch
from
SodaDev:support-output-in-attributesetter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support output value in AttributeSetter #6543
SodaDev
wants to merge
2
commits into
open-telemetry:main
from
SodaDev:support-output-in-attributesetter
+223
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SodaDev
force-pushed
the
support-output-in-attributesetter
branch
4 times, most recently
from
January 2, 2025 15:19
ae8c6cb
to
a976877
Compare
dmathieu
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a changelog entry.
dmathieu
reviewed
Jan 6, 2025
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6543 +/- ##
=====================================
Coverage 68.5% 68.5%
=====================================
Files 200 200
Lines 16768 16800 +32
=====================================
+ Hits 11490 11519 +29
- Misses 4933 4937 +4
+ Partials 345 344 -1
|
SodaDev
force-pushed
the
support-output-in-attributesetter
branch
from
January 6, 2025 12:53
a976877
to
e8d0895
Compare
…with output value. Thanks to that, users can instrument attributes based on the AWS SDK responses.
SodaDev
force-pushed
the
support-output-in-attributesetter
branch
from
January 6, 2025 15:44
e8d0895
to
6e05dfc
Compare
akats7
reviewed
Jan 6, 2025
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go
Show resolved
Hide resolved
akats7
approved these changes
Jan 6, 2025
dmathieu
reviewed
Jan 7, 2025
Co-authored-by: Damien Mathieu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
Add AttributeBuilder, which will extend the AttributeSetter contract with output value. Thanks to that, users can instrument attributes based on the AWS SDK responses.