Implement http.Hijacker for otelmux #6562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 9fa866688216dd5f08a22c5f3c01da3337fc400f Merge: 8b0f94e6 8a49875 Author: Pasha, Rehan <[email protected]> Date: Sat Sep 7 21:58:48 2024 +0530 Merge branch 'main' into fix-5402 Signed-off-by: Pasha, Rehan <[email protected]> commit 8b0f94e6b500c5e2d65d1c65bbcbb63087afe7e7 Author: Pasha, Rehan <[email protected]> Date: Sat Sep 7 21:57:41 2024 +0530 Update CHANGELOG.md Signed-off-by: Pasha, Rehan <[email protected]> commit f76eb1d70480828fb0626b3285a46a82cd6c13a7 Author: Pasha, Rehan <[email protected]> Date: Sat Sep 7 20:35:39 2024 +0530 Delete instrgen/driver/driver Signed-off-by: Pasha, Rehan <[email protected]> commit 158e36cae0eff704203349929c919c0d8f4e669d Author: Rehan Pasha <[email protected]> Date: Sat Sep 7 11:03:24 2024 -0400 Updating test case and lint Signed-off-by: Rehan Pasha <[email protected]> commit 256b7de Author: Rehan Pasha <[email protected]> Date: Tue Aug 27 06:28:33 2024 -0400 Adding test case for otelmux and fixing lint Signed-off-by: Rehan Pasha <[email protected]> Signed-off-by: Rehan Pasha <[email protected]>
Signed-off-by: Rehan Pasha <[email protected]>
Signed-off-by: rehanpfmr <[email protected]>
dmathieu
reviewed
Jan 7, 2025
| @@ -8,6 +8,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - Implement `http.Hijacker` in`go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`. (#5402) | |||
There was a problem hiding this comment.
Suggested change
| - Implement `http.Hijacker` in`go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`. (#5402) | |
| - Implement `http.Hijacker` in`go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`. (#6562) |
|
|
||
| router.ServeHTTP(w, r) | ||
| assert.True(t, called, "failed to run test") | ||
| assert.True(t, called) |
There was a problem hiding this comment.
Why does this test need changing?
| @@ -190,3 +187,18 @@ func TestFilter(t *testing.T) { | |||
| assert.Equal(t, 1, calledHealth, "failed to run test") | |||
| assert.Equal(t, 1, calledTest, "failed to run test") | |||
| } | |||
|
|
|||
| func TestRecordingResponseWriterHijack(t *testing.T) { | |||
There was a problem hiding this comment.
Those two tests need to be fixed (so does the linter).
Also, we should be testing calling Hijack() when hijacker is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5402