Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create better HTML comment parser - Allow more semconv snippet headers. #512

Merged

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Dec 6, 2024

Towards: #501

Create a more flexible HTML comment parser so we don't RELY on spaces to exist to succesfully parse HTML comments.

crates/weaver_semconv_gen/src/parser.rs Fixed Show fixed Hide fixed
crates/weaver_semconv_gen/src/parser.rs Fixed Show fixed Hide fixed
crates/weaver_semconv_gen/src/parser.rs Fixed Show fixed Hide fixed
crates/weaver_semconv_gen/src/parser.rs Fixed Show fixed Hide fixed
@jsuereth jsuereth changed the title Wip loose parsing semconv comments Create better HTML comment parser - Allow more semconv snippet headers. Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.0%. Comparing base (c5c66ba) to head (61f6672).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_semconv_gen/src/parser.rs 91.3% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #512   +/-   ##
=====================================
  Coverage   73.9%   74.0%           
=====================================
  Files         50      50           
  Lines       3911    3930   +19     
=====================================
+ Hits        2894    2911   +17     
- Misses      1017    1019    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel lquerel merged commit 6bdb362 into open-telemetry:main Dec 9, 2024
23 checks passed
@jsuereth jsuereth deleted the wip-loose-parsing-semconv-comments branch December 9, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants