-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weaver Policy Engine #87
Conversation
…ecision by default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=====================================
Coverage 63.6% 63.6%
=====================================
Files 54 56 +2
Lines 3245 3282 +37
=====================================
+ Hits 2065 2089 +24
- Misses 1180 1193 +13 ☔ View full report in Codecov by Sentry. |
I'm trying to simplify as much as possible crate name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was a lot more tearing things apart than I expected, but I think this separation will pay off later!
Thanks for adding this, excited to try it out/expand on it!
This PR is based the proposal #81.
This initial implementation (based on the regorus policy engine) allows for the detection of violations against best practices within a semantic convention registry (before the resolution phase) through one or several policy files (in rego format). A future PR will enable the application of policies after the registry's resolution to detect other types of violations.
A detailed description of the operating principle can be found in the README.md of the
weaver_policy_engine
crate.The impact on performance from evaluating policies on all files in the registry is imperceptible.
Future developments:
weaver registry check
command has the capability to apply these policies. Support for other commands will be added in future PRs.Note: Due to a conflict issue with serde_json, this PR references a fork of the
regorus
project. A description of the problem can be found here. The described issue is not a major problem, and I believe it is temporary.