Update docker publishing to match documentation #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=====================================
Coverage 63.6% 63.6%
=====================================
Files 54 54
Lines 3235 3235
=====================================
Hits 2058 2058
Misses 1177 1177 ☔ View full report in Codecov by Sentry. |
lquerel
approved these changes
Apr 9, 2024
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" |
| - name: Build the Docker image | ||
| run: docker build . -t weaver | ||
| - name: Push the Docker image | ||
| if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
You remove the condition to run this only when merged to main or when tags are added, is this intended?
There was a problem hiding this comment.
for debugging only. The login isn't working, but I figured out why the previous solution wasn't working.
I'm not sure why the SAME secrets won't work with the login action.
|
Closing this for now - will pick it up later, when we want to improve docker publishing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.