chore(api): deprecate MCP connector_id - #3894
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed; 2 generated baselines changed. Compared
45 existing customizations unchanged
5 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35311553740 --repo openai/openai-python \
--name castiron-custom-code-35311553740-1 --dir /tmp/castiron-custom-code-35311553740-1
git apply --stat /tmp/castiron-custom-code-35311553740-1/custom-code.patch
cat /tmp/castiron-custom-code-35311553740-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9a11f6e874292230633073fb64ea6202ad22a1df 1c1c9c7b03dadb610c19f12cb62eb5f30b668409
python3 scripts/castiron/custom_code_report.py report \
--base 9a11f6e874292230633073fb64ea6202ad22a1df \
--head 1c1c9c7b03dadb610c19f12cb62eb5f30b668409 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-1c1c9c7b03da
cat /tmp/castiron-custom-code-1c1c9c7b03da/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Approved. I checked both upstream MCP connector_id schema definitions and the ten generated Python field docstrings. They consistently mark the field as deprecated for post-September 1, 2026 models and point users to server_url or tunnel_id, while preserving the existing field, alternatives, and executable behavior. I found no consequential issue.
Validation: isolated exact-head source review, Python parsing/AST comparison with the base, and git diff --check; no executable statements changed. Exact-head CI tests, lint, compatibility, and security checks are green. I did not run a runtime suite for this documentation-only change.
Codex task: codex://threads/01a0a21f-84b6-7c21-b7a7-30a1e64ab2f9
Summary
Updates MCP tool documentation with deprecation guidance for models released after September 1, 2026.
Changes