add Zap and DelayedZap stimuli, and sinespec factory fct #1
Conversation
|
I had to restrain the version of pydantics when building docs because sphinx breaks for the latest version. We might be able to get back to latest pydantic version once this issue on sphinx-autodocs-typehints is solved: tox-dev/sphinx-autodoc-typehints#479 |
There was a problem hiding this comment.
Thanks!
Will this lead to the a new release in pypi? Do we have everything correctly set-up?
Should we mention in BlueBrain repository of bluecellulab that the future development has moved to this repository? I think we all should discuss before merging this
bluecellulab/stimulus/factory.py
Outdated
| post_delay: float, | ||
| amplitude: float, | ||
| ) -> CombinedStimulus: | ||
| """Create a DelayedYap stimulus from given time events and amplitude. |
There was a problem hiding this comment.
DelayedZap instead of DelayedYap :)
There was a problem hiding this comment.
Good catch. Fixed in latest commit
| @@ -561,3 +643,47 @@ def neg_cheops( | |||
| + Empty(self.dt, duration=post_delay) | |||
| ) | |||
| return result | |||
|
|
|||
| def sinespec( | |||
There was a problem hiding this comment.
I hope all the parameters and formulae in sinespec are the same as those that we have in bluepyemodel ecode of the sinespec
There was a problem hiding this comment.
Yes, thanks to the power of copy/pasting!
|
@darshanmandge that is the joy of not being admin, I don't know if we have the PyPi registered or not, and I can't set them myself. @heerener could you set the CODECOV_TOKEN and the PYPI_PASSWORD in this repo's secrets, pretty please? |
with tests :)