New set-as-path BGP action, and support last AS for for setting AS path. #1148
Conversation
|
/gcbrun |
|
No major YANG version changes in commit fd28c04 |
|
Removed the extra comma and rebased against master. |
|
/gcbrun |
xuqma
force-pushed
the
master
branch
3 times, most recently
from
68a38ff to
bffc29b
Compare
|
/gcbrun |
| set-as-path action"; | ||
|
|
||
| leaf-list as-paths { | ||
| type union { |
There was a problem hiding this comment.
I think this need to be ordered-by-user .
Is there precedence for this in existing implementations or is this intended to be a new feature request?
There was a problem hiding this comment.
Good call. Updated type with ordered-by user.
IIUC, only Arista support replacing the entire AS path with [set as-path match all replacement] (https://www.arista.com/en/um-eos/eos-acls-and-route-maps#xx1313923). This is the recommended Arista implementation for the existing as-path-expand in Juniper, which is also vendor specific unefortunately. I am not sure which one fits the model better (neither is ideal due to single-vendor support). set-as-path might be slightly more generic based on our past discussions. Kindly share your thoughts please.
There was a problem hiding this comment.
Ok, we can declare OC which achieves an operational use case that multiple vendors only deliver by different syntax/schema and semantics.
In this case I think the guiding principle is intact, in that the use case can be delivered by multiple vendors. It is ok for OC to adopt a syntax that looks more like one implementation than the others, when they are all different. The alternative is for OC to contrive some schema that that no existing implementation has, just to be different. I'd rather go with what operators have some rough consensus is "easy enough" to use.
xuqma
force-pushed
the
master
branch
3 times, most recently
from
b8f43f3 to
61d8291
Compare
xuqma
force-pushed
the
master
branch
2 times, most recently
from
fb94dc8 to
b9068be
Compare
xuqma
changed the title
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
|
LGTM, moving to last call for Jan 16, 2025 |
xuqma
force-pushed
the
master
branch
2 times, most recently
from
30ffc7e to
bdeb512
Compare
|
Thanks Darren! I have fixed the revisions based on the previous check result. |
Change Scope
/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/set-as-path(a list of ASNs or last-as)oc-bgp-polinstead ofoc-bgp-types.New paths after the model update:
Platform Implementations