Hide the emulator's error dialogs before the instrumented tests - #686
Merged
Merged
Conversation
In run 35964496350 (#679), DarkModeTests.theDrawnPageIsDark and theSwitchDarkensADayModeApp failed on API 34 with "the page stayed light - mean luminance 193". The screenshots the tests kept show a dark page. A "Pixel Launcher isn't responding" dialog covers the middle of the screen, which is the part that the tests measure. The script now sets hide_error_dialogs before the tests. With it, the system stops an app that does not respond and shows no dialog. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Ph3Q6se1Ah28qfcunYHG7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In run 35964496350 (#679),
DarkModeTests.theDrawnPageIsDarkandtheSwitchDarkensADayModeAppfailed on API 34 (foss):The screenshots that the tests kept show a dark page. A "Pixel Launcher isn't responding" dialog covers the middle third of the screen, and
meanLuminance()measures that part. The app works. The launcher of the emulator stopped responding during the test.Change
run-instrumented-tests.shrunsadb shell settings put global hide_error_dialogs 1beforeconnectedCheck. With this setting, the system does not show crash or ANR dialogs, and it stops an app that does not respond. A crash in our app still fails its test, because the instrumentation reports it.Not verified
|| truekeeps the run going.This happened once in the last five runs on main. One green run does not prove the fix.
🤖 Generated with Claude Code