Conversation
Add read-only ecoMain and ecoSub measurement support with logical meter configuration, device identity validation, documentation, examples, and tests.
Member
|
Thanks for the PR. Does ecoMain uses standard modbus TCP? If so, it would be best to make use of the existing modbusTCP interfacer: https://github.com/openenergymonitor/emonhub/tree/master/conf/interfacer_examples/modbus Modifications or extensions to the existing modbusTCP interfacer would be prefered rather than adding a whole new interfacer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hello OpenEnergyMonitor team,
We are the enecess team. First of all, thank you for your continued work on OpenEnergyMonitor and its open energy monitoring ecosystem.
We would like to contribute a Modbus TCP integration for ecoMain to emonHub.
ecoMain can measure a three-phase main circuit and 10 branch circuits. Up to three ecoSub units can be added, extending the system to a total of 40 branch circuits. The new
EmonHubEcoMainInterfacerreads these measurements and publishes them to Emoncms through the existing emonHub data flow.Main features
The integration is strictly read-only and only uses Modbus function code
03. It does not write registers, change device settings, or control external devices. It also does not change the behavior of the emonHub core framework.Validation
Documentation
Thank you for taking the time to review this pull request. We welcome your feedback and are happy to refine the implementation in line with emonHub's project conventions.