Make Connected Apps links available in Transifex

[drummer83]

What? Why?

Following the discussion here on Slack I've made the links on the Connected Apps page available in Transifex so they can be edited without a code change.

What should we test?

• Activate the feature toggle for Connected Apps.
• Visit /admin/enterprises/Enterprise_Name/edit#/connected_apps_panel.
• Test that the displayed description text, the displayed link and the link URL are still the same and working correctly.
• Link should open in a new browser tab.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

[dacook]

Thanks for trying this out.

I think the intention was to have it as one general-purpose rich text editor so that you can customise it as needed. This is more flexible to cater for different use cases.

I see that transifex doesn't have the simple rich text editor that I hoped, but I was able to edit the existing URL which should be enough for @RachL's use case. Does this that solve the problem?

[mkllnk]

The current HTML block makes it easier to change the content and even add more than one link. So I wouldn't split it like in this pull request. I agree though that Transifex makes editing really difficult. Their intention is good: prevent people from breaking code. But it's really hard to change.

[drummer83]

Maybe we could hear a comment from @openfoodfoundation/train-drivers-product-owners, like @RachL.

First of all, I think the functionality to see and even change HTML in Transifex is new. Not super new, but that's why we weren't aware of it.

Also, I think that having the HTML in Transifex is a completely new approach we haven't been using yet to such an extent - afaik. It may be tempting and promising to do so, but then it should be applied to many other parts of the app as well. But some things come to my mind:

• a change of concept should be agreed on in the product or delivery circle,
• not all our translators are HTML coders, and a lot can go wrong,
• each iteration of finding and fixing mistakes requires a full week.

[dacook]

For this case, I think it's worth considering moving these descriptions out of translations, and into instance config (eg a new tab under /admin/general_settings). This would allow instance managers to configure for their context, and use a rich text editor.

I also have a suggestion for the current VINE use case, see mentioned PR. Is it possible to work on this as part of the funded feature?

[RachL]

Yes I agree with @drummer83 I don't think we can rely on changing the HTML. I will try to find budget for the settings ASAP and in the meantime maybe thanks for this PR @drummer83 !

[mkllnk]

Okay. If changing the HTML is too hard then let's do the non-html version for now.

[RachL]

many thanks @drummer83 ❤️ LGTM! Merging :)