Don't show stock for on-demand inventory items #13064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed to tracking stock of on-demand items to be able to place backorders. This is mostly hidden in the app but was still visible on the inventory page. Now we are hiding that here, too.
mkllnk
added
the
user facing changes
mkllnk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
It seems that we have a bug around subscriptions and negative stock levels. It has not been filed on Github yet but is discussed on Slack:
While the details are not all confirmed yet, one confusing part is that on-demand products show negative stock levels on the inventory page. The UI was assuming that on-demand products don't have a stock level set. But we are tracking stock levels since Track (negative) stock for on-demand products and overrides #12726.
I'm a bit hesitant to present this fix because it could make investigation of the actual bug more difficult by hiding the stock level. Ideally, we would solve the subscription bug first but we don't have a confirmed description yet. So we may wait merging this until we started work on the subscription issue.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates