Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CAEP event - Risk level change event #205
base: main
Are you sure you want to change the base?
New CAEP event - Risk level change event #205
Changes from all commits
d8efd7e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@appsdesh any thoughts on changing this to a numeric value on a fixed scale (e.g. 10)? We discussed this during the SSWG meeting on 11/5, but I don't remember if we agreed to switch to a numeric value. three of those values could map to "low", "medium" and "high" as you require, but it will give a little more expressivity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tulshi welcome back! we already aligned on it in one of the comments here.
I have seen many vendors with LOW, MED, HIGH scoring that is visible to the admin and users. It would be difficult/arbitrary to map these on the numeric scale. Instead, numeric values could be easier to map on enum. Hence I am in favor of additional field if there is a strong usecase, rather than replacement.