-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging rework #69
Logging rework #69
Conversation
a new module to satisfy the max branches limit.
I merged the openmsitoolbox PR so the OpenMSILogger class is now updated. Would you please run the run-tests-no-kafka test again to clear the checks before I merge? (I hope that is all it was.). Thanks. |
@davidelbert : thanks. That did not fix it because although a new v1.2.4 was tagged for openmsitoolbox, it was not pushed to PyPI (and the code version string was not updated beyond v1.2.3). I've submitted a second PR over there for that: openmsi/openmsitoolbox#10 , but not sure the process to issue a new PyPI release. |
@tmcqueen-materials, openmsitoolbox has new version on PyPi now. It's tagged "openmsitoolbox 1.2.4.post1" as you suggested. Are you now able to rerun the CircleCI pipeline? Thanks. |
@tmcqueen-materials you'll also have to bump version of openmsistream itself to make tests pass, e.g.:
|
@Xarthisius : Thanks. It looks like this has surfaced a different long-standing nit in the ssl ca location handling code that I'm going to go fix now... |
@Xarthisius , @davidelbert : At this point, this should be ready for review. The failing tests are associated with what looks like a CI issue and trying to test S3 bucket functionality. Let me know of any changes that are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would only add explicit version dependency to:
so that it picks up openmsitoolbox with proper changes.
@Xarthisius : great idea. Just pushed that change. |
Merging without the python matrix CircleCI tests passing. They are failing because of lack of S3 bucket writing test endpoint that I can fix later once JetStream2 is back from service or the local allocations are up. |
The process of debugging OpenMSIStream zombie states, where everything is "running" but message consumption has ceased (probably due to an underlying bug in the rdkafka library, see confluentinc/librdkafka#4916 ) was complicated by the suppression of most log information from the Kafka producers/consumers.
This PR removes the log suppression and propagates log level sets appropriately. Part of doing this is removing a dependency on (undocumented, internal) parts of KafkaCrypto, which made me realize message size accounting associated with heartbeats is incorrect.
Creating as a draft PR to see what the runners think. Requires openmsi/openmsitoolbox#8 .