rte: metrics: merge manifests into existing manifests handling #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce higher-level objectstate/rte Manifests object to enable future integration between deployer manifests and operator-specific RTE metrics manifests. This change only create room for the future integration adding a higher level object. No changes in behavior besides required API changes. Signed-off-by: Francesco Romani <[email protected]>
Incorporate the operator-specific metrics manifests in the newly introduced higher level objectstate Manifests. This enables us to remove all the custom code. Signed-off-by: Francesco Romani <[email protected]>
add coding shortcuts to remove the repetitive code. No intended changes in behavior. Signed-off-by: Francesco Romani <[email protected]>
openshift-ci
bot
added
the
approved
|
/cc @rbaturov |
make sure to render the Service manifests in render mode. Signed-off-by: Francesco Romani <[email protected]>
rbaturov
reviewed
Dec 30, 2024
I really like these changes. |
|
/approve Thanks! |
Tal-or
approved these changes
Jan 2, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having very custom processing of RTE metrics manifests, generalize the current RTE manifests handling and merge the metrics manifests in this flow. Benefits are more common code and less special cases. No expected changes in the operator behavior.