-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA:reconcile azure creds to a fixed secret in hcp namespace #5347
base: release-4.17
Are you sure you want to change the base?
NO-JIRA:reconcile azure creds to a fixed secret in hcp namespace #5347
Conversation
@Patryk-Stefanski: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Patryk-Stefanski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aks |
@Patryk-Stefanski: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hey @Patryk-Stefanski It's not usual to put a PR against 4.17 directly, is this blocking you? It's there any way to use the typical backport flow to follow in this case? |
This is one of the things that is causing the 4.17 aks e2e to fail, there is a change in 4.18 that fixes this but it requires a manual backport of a few different PRs, I was hoping this would be a quick fix. We might not need a 4.17 aks e2e, @bryan-cox any update on that ? We can close this PR if we don't need 4.17. |
@Patryk-Stefanski no update right now |
What this PR does / why we need it:
This is blocking 4.17 aks e2e as it cannot create an HC because the reconcile of cloud credentials is blocking progression as it is unable to find the -cloud-credentials secret in HCP NS as made in the HC NS. In newer releases, we use a fixed secret in the HCP namespace instead so this is copying that behavior.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist