Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA:reconcile azure creds to a fixed secret in hcp namespace #5347

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Conversation

Patryk-Stefanski
Copy link
Contributor

What this PR does / why we need it:
This is blocking 4.17 aks e2e as it cannot create an HC because the reconcile of cloud credentials is blocking progression as it is unable to find the -cloud-credentials secret in HCP NS as made in the HC NS. In newer releases, we use a fixed secret in the HCP namespace instead so this is copying that behavior.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

@Patryk-Stefanski: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
This is blocking 4.17 aks e2e as it cannot create an HC because the reconcile of cloud credentials is blocking progression as it is unable to find the -cloud-credentials secret in HCP NS as made in the HC NS. In newer releases, we use a fixed secret in the HCP namespace instead so this is copying that behavior.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 7, 2025
@openshift-ci openshift-ci bot requested review from enxebre and hasueki January 7, 2025 11:17
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release labels Jan 7, 2025
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Patryk-Stefanski
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Patryk-Stefanski
Copy link
Contributor Author

/test e2e-aks

Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

@Patryk-Stefanski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks 5fef068 link false /test e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jparrill
Copy link
Contributor

jparrill commented Jan 9, 2025

Hey @Patryk-Stefanski It's not usual to put a PR against 4.17 directly, is this blocking you? It's there any way to use the typical backport flow to follow in this case?

@Patryk-Stefanski
Copy link
Contributor Author

It's not usual to put a PR against 4.17 directly, is this blocking you? It's there any way to use the typical backport flow to follow in this case?

This is one of the things that is causing the 4.17 aks e2e to fail, there is a change in 4.18 that fixes this but it requires a manual backport of a few different PRs, I was hoping this would be a quick fix.

We might not need a 4.17 aks e2e, @bryan-cox any update on that ? We can close this PR if we don't need 4.17.

@bryan-cox
Copy link
Member

It's not usual to put a PR against 4.17 directly, is this blocking you? It's there any way to use the typical backport flow to follow in this case?

This is one of the things that is causing the 4.17 aks e2e to fail, there is a change in 4.18 that fixes this but it requires a manual backport of a few different PRs, I was hoping this would be a quick fix.

We might not need a 4.17 aks e2e, @bryan-cox any update on that ? We can close this PR if we don't need 4.17.

@Patryk-Stefanski no update right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants